Skip to content

Conversation

@KnutAM
Copy link
Contributor

@KnutAM KnutAM commented Nov 10, 2025

Calling BlockIndex((1.0, 2.0), (1,2)) currently causes an infinite growth of the tuple b, which this PR fixes by requiring tuple a to have integer elements. This lead to the computer just working for a very long time (at least 10 minutes) without any error message.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.53%. Comparing base (7ebbea7) to head (4c8ad37).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   94.52%   94.53%           
=======================================
  Files          19       19           
  Lines        1789     1810   +21     
=======================================
+ Hits         1691     1711   +20     
- Misses         98       99    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Collaborator

Good catch, thanks for fixing that.

@mtfishman mtfishman merged commit dd3de80 into JuliaArrays:master Nov 10, 2025
18 checks passed
@KnutAM
Copy link
Contributor Author

KnutAM commented Nov 10, 2025

Thanks for quick response and merge!

@KnutAM KnutAM deleted the kam/fixfloatindex branch November 10, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants