-
Notifications
You must be signed in to change notification settings - Fork 30
Add missing BroadcastStyle and MemoryLayouts for cache styles #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 95.88% 95.89% +0.01%
==========================================
Files 17 17
Lines 3351 3360 +9
==========================================
+ Hits 3213 3222 +9
Misses 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlfivefifty
requested changes
Nov 13, 2025
dlfivefifty
pushed a commit
to JuliaLinearAlgebra/ArrayLayouts.jl
that referenced
this pull request
Nov 18, 2025
Before: ```julia-repl julia> using LazyArrays; v = ((1:10_000) .* LazyArrays.AccumulateAbstractVector(*, 1:10_000'))'; @time v[1:1, 1:10_000]; 0.031649 seconds (476.63 k allocations: 12.861 MiB) ``` After: ```julia-repl julia> using LazyArrays; v = ((1:10_000) .* LazyArrays.AccumulateAbstractVector(*, 1:10_000'))'; @time v[1:1, 1:10_000]; 0.000031 seconds (65 allocations: 2.156 KiB) ``` (Improved timings also require JuliaArrays/LazyArrays.jl#387)
Collaborator
Author
|
Found a better fix for the StackOverflow issue. It seems it was just a missing method for |
dlfivefifty
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for what we were discussing @dlfivefifty. WIP because I need to fix this new StackOverflow
Also doesn't really change any of the timing issues we found - they're still on the same scale. Gotta do more digging. Creating the PR now just incase I can see what other downstream stuff might be breaking.