Skip to content

Conversation

@mileslucas
Copy link
Member

@mileslucas mileslucas commented Sep 30, 2019

This will fix the current issues with docstrings and images on the documentation

  • Fix images not posting on hosted documentation
  • Fix dosctrings not rendering properly
  • Switch to using datadeps for the sfd map

This should be resolved and merged before we release v0.6.0.

@mileslucas mileslucas added the WIP label Sep 30, 2019
@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #8 into master will increase coverage by 1.96%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   97.05%   99.01%   +1.96%     
==========================================
  Files           3        3              
  Lines         102      102              
==========================================
+ Hits           99      101       +2     
+ Misses          3        1       -2
Impacted Files Coverage Δ
src/DustExtinction.jl 100% <100%> (ø) ⬆️
src/dust_maps.jl 100% <100%> (+3.63%) ⬆️
src/color_laws.jl 97.61% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbccdb...6ce8463. Read the comment docs.

@mileslucas
Copy link
Member Author

Problems have been fixed (huge thanks to @mortenpi for catching a unicode whitespace error). Ready for review.

@mileslucas mileslucas removed the WIP label Sep 30, 2019
@mileslucas mileslucas requested a review from giordano September 30, 2019 22:12
@giordano giordano changed the title Fixes Fixes to documentation and switch to using datadeps for the sfd map Sep 30, 2019
@giordano giordano merged commit a39125b into JuliaAstro:master Sep 30, 2019
@mileslucas mileslucas deleted the fixes branch September 30, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants