prefixsum for non-positive index in FenwickTree #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that `prefixsum(ft, x)` should give `0` instead of an ArgumentError, just like how `sum([12,3,4,5,6][1:0]) = 0`.
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=========================================
+ Coverage 95.04% 95.15% +0.1%
=========================================
Files 33 33
Lines 2825 2827 +2
=========================================
+ Hits 2685 2690 +5
+ Misses 140 137 -3
Continue to review full report at Codecov.
|
Member
|
cool! I would certainly say that since |
eulerkochy
requested changes
Apr 4, 2020
Member
eulerkochy
left a comment
eulerkochy
left a comment
There was a problem hiding this comment.
Can you add tests for the change? Then I think this PR is good to go!
eulerkochy
changed the title
eulerkochy
added
bug
Needs tests
Co-Authored-By: Koustav Chowdhury <kc99.kol@gmail.com>
eulerkochy
removed
the
Needs tests
eulerkochy
approved these changes
Apr 4, 2020
Member
eulerkochy
left a comment
eulerkochy
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution! 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that
prefixsum(ft, x)should give0whenx<1instead of an ArgumentError, just like howsum([12,3,4,5,6][1:0]) = 0.In particular I was editing some code, and I assumed that
sum(my_array[1:x]) == prefixsum(FenwickTree(my_array), x)would always betrue. I was surprised that it wasn'ttruefor allx, and think that this should be changed.