Slightly improve handling of kwcall
definition lookup failure
#147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Cthulhu tests, I caught an error where we try to get the definition of
kwcall
itself from https://github.com/JuliaLang/julia/blob/12f7bb52e5714c577189665a05606e3764f333cf/base/boot.jl#L366, and our handling fails thinking that it's a "wrapping"kwcall
(and not an actual definition).I don't think we can support parsing that well, so I just disabled that particular test in Cthulhu, but the failure mode was a bit obscure: it complained in our check
T <: Function
thatT
must be a type, and wasVararg
, which this PR tries to make a bit clearer.A very minor improvement, but I thought it wouldn't hurt to improve things once I figured out the reason for the subtyping check failure.