Implement an initial API #2
Conversation
src/CodeTracking.jl
Outdated
| file, line = fileline(lin) | ||
| end | ||
| if !isabspath(file) | ||
| # This is a Base method |
timholy
force-pushed
the
teh/definition
branch
from
d610a67 to
8d00f9f
Compare
timholy
changed the title
definition(method, String) and add internal data
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=====================================
Coverage ? 0%
=====================================
Files ? 3
Lines ? 63
Branches ? 0
=====================================
Hits ? 0
Misses ? 63
Partials ? 0
Continue to review full report at Codecov.
|
|
Well, this has grown. I think this might be the complete API in terms of currently-planned functionality. I also have a local Revise branch that interacts successfully with this package. |
timholy
force-pushed
the
teh/definition
branch
from
b23d66e to
51dfd33
Compare
|
I've pushed a I'm eager to get this registered (3-day delay), so barring concerns about the API I will merge later this morning. |
|
Should have pinged @KristofferC. |
src/CodeTracking.jl
Outdated
| definition(method::Method) = definition(method, Expr) | ||
|
|
||
| """ | ||
| info = pkgfiles(id::PkgId) |
There was a problem hiding this comment.
PkgId itself is AFAIU undocumented and internal. So should the API be based on package name and UUID (which are public) rather than the internal struct PkgId?
There was a problem hiding this comment.
Or on PackageSpec (which is also exported, iirc)?
| function pkgfiles(name::AbstractString) | ||
| project = Base.active_project() | ||
| uuid = Base.project_deps_get(project, name) | ||
| uuid == false && error("no package ", name, " recognized") |
There was a problem hiding this comment.
Does it make sense to error here or just return nothing like when it's a real installed package that just hasn't been loaded yet?
There was a problem hiding this comment.
Erroring seems like a good choice to me. And it is at least the conservative choice which can be relaxed later.
Here's the beginning of real forward-movement on this package. The proposed public API is in
CodeTracking.jlitself, the other files are internal. Comments welcome.