Skip to content

Use abspath on filenames #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Use abspath on filenames #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8aa80
Use abspath on filenames (fixes #23)
timholy Mar 18, 2019
c8e0e59
Clarify an error message
timholy Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CodeTracking.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ Return the signatures of all methods whose definition spans the specified locati
Returns `nothing` if there are no methods at that location.
"""
function signatures_at(filename::AbstractString, line::Integer)
filename = abspath(filename)
if occursin(juliabase, filename)
rpath = postpath(filename, juliabase)
id = PkgId(Base)
Expand All @@ -139,7 +140,7 @@ function signatures_at(filename::AbstractString, line::Integer)
end
end
end
error("$filename not found, perhaps the package is not loaded")
error("$filename not found in internal data, perhaps the package is not loaded (or not loaded with `includet`)")
end

"""
Expand Down
5 changes: 4 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ using CodeTracking
using Test, InteractiveUtils
# Note: ColorTypes needs to be installed, but note the intentional absence of `using ColorTypes`

include("script.jl")
isdefined(Main, :Revise) ? includet("script.jl") : include("script.jl")

@testset "CodeTracking.jl" begin
m = first(methods(f1))
Expand Down Expand Up @@ -87,5 +87,8 @@ end
@test !isempty(sigs)
sigs = signatures_at(Base.find_source_file(String(m.file)), m.line)
@test !isempty(sigs)

# issue #23
@test !isempty(signatures_at("script.jl", 9))
end
end