Skip to content

Fix definition(String, m) for methods defined at the REPL #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix definition(String, m) for methods defined at the REPL #30

merged 1 commit into from
Apr 3, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Apr 3, 2019

Looks like a typo from a refactoring. A test is being added to Revise.

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #30   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         158   158           
====================================
  Misses        158   158
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c509f1...7176fe2. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #30   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         158   158           
====================================
  Misses        158   158
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c509f1...7176fe2. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 3, 2019 •
edited
Loading

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #30   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         158   158           
====================================
  Misses        158   158
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c509f1...7176fe2. Read the comment docs.

@timholy timholy merged commit 2a084e7 into master Apr 3, 2019
@timholy timholy deleted the teh/fix_repl branch April 3, 2019 11:57
timholy added a commit to timholy/Revise.jl that referenced this pull request Apr 3, 2019
@timholy
Add test for JuliaDebug/CodeTracking.jl#30
43043b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@timholy