Skip to content

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Apr 6, 2019

Fixes #41

@timholy
Copy link
Member

timholy commented Apr 6, 2019

Let's get this merged too and then tag a new release. I pre-approve your final version sight unseen 😄.

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d15af5a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #43   +/-   ##
======================================
  Coverage          ?    0%           
======================================
  Files             ?     3           
  Lines             ?   165           
  Branches          ?     0           
======================================
  Hits              ?     0           
  Misses            ?   165           
  Partials          ?     0
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15af5a...3ac34eb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d15af5a). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             master   #43   +/-   ##
======================================
  Coverage          ?    0%           
======================================
  Files             ?     3           
  Lines             ?   165           
  Branches          ?     0           
======================================
  Hits              ?     0           
  Misses            ?   165           
  Partials          ?     0
Impacted Files Coverage Δ
src/utils.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15af5a...3ac34eb. Read the comment docs.

@KristofferC
Copy link
Member Author

I'll be away for a few hours but I did a feeble attempt to rebase this with the Github UI. Feel free to fixup / merge / tag a new release if you want to get a new one out quickly.

@timholy timholy merged commit d21c477 into master Apr 6, 2019
@timholy timholy deleted the kc/macros branch April 6, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants