-
Notifications
You must be signed in to change notification settings - Fork 11
Strip final line endings (fix #42) #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't think this fixes #42 because that is about all line endings, and not only the final one. |
https://github.com/JuliaRegistries/General/search?q=CodeTracking&unscoped_q=CodeTracking is a poor mans replacement |
appveyor.yml
Outdated
@@ -0,0 +1,44 @@ | |||
environment: | |||
matrix: | |||
- julia_version: 0.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps drop 0.7?
Apparently it does. |
c5aebde
to
acf0dce
Compare
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 165 165
====================================
Misses 165 165
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 165 165
====================================
Misses 165 165
Continue to review full report at Codecov.
|
Thanks! Looks like it's all "our world" so I suppose we could do either. Not even MagneticReadHead lists it (which is a bug on their part). Technically it is breaking but confess some reluctance to update compat entries for such a small change. |
Yeah, just go patch release imo. |
Is this change sufficiently breaking that we need to bump the minor version number? (We don't have the equivalent of
Pkg.dependents
yet, do we?)