Skip to content

Conversation

timholy
Copy link
Member

@timholy timholy commented Apr 6, 2019

Is this change sufficiently breaking that we need to bump the minor version number? (We don't have the equivalent of Pkg.dependents yet, do we?)

@KristofferC
Copy link
Member

I don't think this fixes #42 because that is about all line endings, and not only the final one.

@KristofferC
Copy link
Member

(We don't have the equivalent of Pkg.dependents yet, do we?)

https://github.com/JuliaRegistries/General/search?q=CodeTracking&unscoped_q=CodeTracking is a poor mans replacement

appveyor.yml Outdated
@@ -0,0 +1,44 @@
environment:
matrix:
- julia_version: 0.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps drop 0.7?

@KristofferC
Copy link
Member

I don't think this fixes #42 because that is about all line endings, and not only the final one.

Apparently it does.

@timholy timholy force-pushed the teh/add_appveyor branch from c5aebde to acf0dce Compare April 6, 2019 10:22
@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #44   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         165   165           
====================================
  Misses        165   165
Impacted Files Coverage Δ
src/CodeTracking.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276e3b0...acf0dce. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #44   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           3     3           
  Lines         165   165           
====================================
  Misses        165   165
Impacted Files Coverage Δ
src/CodeTracking.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276e3b0...acf0dce. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Apr 6, 2019

https://github.com/JuliaRegistries/General/search?q=CodeTracking&unscoped_q=CodeTracking is a poor mans replacement

Thanks! Looks like it's all "our world" so I suppose we could do either. Not even MagneticReadHead lists it (which is a bug on their part). Technically it is breaking but confess some reluctance to update compat entries for such a small change.

@KristofferC
Copy link
Member

Yeah, just go patch release imo.

@timholy timholy merged commit d15af5a into master Apr 6, 2019
@timholy timholy deleted the teh/add_appveyor branch April 6, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants