Return nothing for methods with line == 0
#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Aug 23, 2019
timholy
force-pushed
the
teh/kwmethnone
branch
from
f78e2f3 to
91121c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 165 166 +1
====================================
- Misses 165 166 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 165 166 +1
====================================
- Misses 165 166 +1
Continue to review full report at Codecov.
|
oxinabox
approved these changes
Aug 23, 2019
|
I declare this non-breaking since it only affects methods that would have formerly thrown an error. So I'll just bump the patch level for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #48