Skip to content

Conversation

timholy
Copy link
Member

@timholy timholy commented May 30, 2020

Fixes #55

I plan to release this as 1.0 after this merges, ref #58 (comment).

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #59   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           3       3           
  Lines         193     193           
======================================
  Misses        193     193           
Impacted Files Coverage Δ
src/CodeTracking.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0823435...ddfd888. Read the comment docs.

.travis.yml Outdated
Comment on lines 25 to 26
Pkg.add(PackageSpec(url="https://github.com/JuliaDebug/JuliaInterpreter.jl", rev="ct1"));
Pkg.add(PackageSpec(url="https://github.com/timholy/Revise.jl", rev="revise3"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need to be removed after some releases are made?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even before merging. These are not needed for package functionality, but this runs the Revise tests and the circular dependency means we need a compatible version of Revise.

Copy link
Member Author

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oxinabox!

.travis.yml Outdated
Comment on lines 25 to 26
Pkg.add(PackageSpec(url="https://github.com/JuliaDebug/JuliaInterpreter.jl", rev="ct1"));
Pkg.add(PackageSpec(url="https://github.com/timholy/Revise.jl", rev="revise3"));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even before merging. These are not needed for package functionality, but this runs the Revise tests and the circular dependency means we need a compatible version of Revise.

@timholy timholy merged commit afc73a9 into master Jun 7, 2020
@timholy timholy deleted the teh/multidef branch June 7, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple definitions; good design for limiting allocation?

2 participants