-
Notifications
You must be signed in to change notification settings - Fork 11
Support multiple definitions for a particular signature #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 3 3
Lines 193 193
======================================
Misses 193 193
Continue to review full report at Codecov.
|
.travis.yml
Outdated
Pkg.add(PackageSpec(url="https://github.com/JuliaDebug/JuliaInterpreter.jl", rev="ct1")); | ||
Pkg.add(PackageSpec(url="https://github.com/timholy/Revise.jl", rev="revise3")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these need to be removed after some releases are made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even before merging. These are not needed for package functionality, but this runs the Revise tests and the circular dependency means we need a compatible version of Revise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oxinabox!
.travis.yml
Outdated
Pkg.add(PackageSpec(url="https://github.com/JuliaDebug/JuliaInterpreter.jl", rev="ct1")); | ||
Pkg.add(PackageSpec(url="https://github.com/timholy/Revise.jl", rev="revise3")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even before merging. These are not needed for package functionality, but this runs the Revise tests and the circular dependency means we need a compatible version of Revise.
Fixes #55
I plan to release this as 1.0 after this merges, ref #58 (comment).