Get tests working on recent Julia versions #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also exposed some previously-untested functionality on Julia 1.0, in particular the absence of `splitpath` on Julia 1.0. I'm not sure what could have changed, but maybe the improvement to `checkname` ended up hitting new code paths on 1.0?
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 60.47% 55.02% -5.46%
==========================================
Files 3 3
Lines 210 229 +19
==========================================
- Hits 127 126 -1
- Misses 83 103 +20
Continue to review full report at Codecov.
|
|
Ah, the answer is that one needs to test with Revise to hit those paths. I happened to do that locally, but here codecov is complaining because almost none of the added code is being tested. I'll merge this anyway despite the pessimistic coverage report because I know it's an improvement from local testing. May be time to take another look at #57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also exposed some previously-untested functionality on Julia 1.0,
in particular the absence of
splitpathon Julia 1.0.I'm not sure what could have changed, but maybe the improvement
to
checknameended up hitting new code paths on 1.0?