Skip to content

make string definition work on call overloadable structs #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022
Merged

make string definition work on call overloadable structs #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ function checkname(fdef::Expr, name)
(fdef.head === :where || fdef.head == :(::)) && return checkname(fproto, name)
fdef.head === :call || return false
if fproto isa Expr
fproto.head == :(::) && return fproto.args[2] == name
# A metaprogramming-generated function
fproto.head === :$ && return true # uncheckable, let's assume all is well
# Is the check below redundant?
Expand Down
9 changes: 9 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,12 @@ end
body, _ = CodeTracking.definition(String, @which Foo.Bar.fit(1, 2))
@test body == "Foo.Bar.fit(a, b) = a + b"
end

struct CallOverload
z
end
(f::CallOverload)(arg) = f.z + arg
@testset "call syntax" begin
body, _ = CodeTracking.definition(String, @which CallOverload(1)(1))
@test body == "(f::CallOverload)(arg) = f.z + arg"
end