Skip to content

remove NanMath and SpecialFunctions.jl #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021
Merged

remove NanMath and SpecialFunctions.jl #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/ChainRules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,4 @@ include("rulesets/LinearAlgebra/factorization.jl")

include("rulesets/Random/random.jl")

# Note: The following is only required because package authors sometimes do not
# declare their own rules using `ChainRulesCore.jl`. For arguably good reasons.
# So we define them here for them.
function __init__()
@require NaNMath="77ba4419-2d1f-58cd-9bb1-8ffee604a2e3" begin
include("rulesets/packages/NaNMath.jl")
end

# Note: drop SpecialFunctions dependency in next breaking release
# https://github.com/JuliaDiff/ChainRules.jl/issues/319
@require SpecialFunctions="276daf66-3868-5448-9aa4-cd146d93841b" begin
if !isdefined(SpecialFunctions, :ChainRulesCore)
include("rulesets/packages/SpecialFunctions.jl")
end
end
end

end # module
38 changes: 0 additions & 38 deletions src/rulesets/packages/NaNMath.jl
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/rulesets/packages/README.md
View file
Open in desktop

This file was deleted.

123 changes: 0 additions & 123 deletions src/rulesets/packages/SpecialFunctions.jl
View file
Open in desktop

This file was deleted.

Empty file removed test/rulesets/packages/NaNMath.jl
View file
Open in desktop
Empty file.
109 changes: 0 additions & 109 deletions test/rulesets/packages/SpecialFunctions.jl
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,5 @@ println("Testing ChainRules.jl")
include_test("rulesets/Random/random.jl")
end
println()

@testset "packages" begin
include_test("rulesets/packages/NaNMath.jl")
# Note: drop SpecialFunctions dependency in next breaking release
# https://github.com/JuliaDiff/ChainRules.jl/issues/319
if !isdefined(SpecialFunctions, :ChainRulesCore)
include_test("rulesets/packages/SpecialFunctions.jl")
end
end
println()
end
end