Skip to content

remove references to SpecialFunctions and NaNMath in the docs #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2021
Merged

remove references to SpecialFunctions and NaNMath in the docs #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d0e181
remove references to SpecialFunctions and NaNMath in the docs
Jun 2, 2021
e353c97
Update docs/src/FAQ.md
mzgubic Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/src/FAQ.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ AD systems making use of `frule`s and `rrule`s should load ChainRules.jl.

## Where should I put my rules?

We recommend adding custom rules to your own packages with [ChainRulesCore.jl](https://github.com/JuliaDiff/ChainRulesCore.jl), rather than adding them to ChainRules.jl.
A few packages - currently SpecialFunctions.jl and NaNMath.jl - have rules in ChainRules.jl as a short-term measure.
We recommend adding custom rules to your own packages with [ChainRulesCore.jl](https://github.com/JuliaDiff/ChainRulesCore.jl).
It is good to have them in the same pacakge that defines the original function.
This avoids type-piracy, and makes it easy to keep in-sync.
ChainRulesCore is a very light weight dependency.

## How do I test my rules?

Expand Down