Add tests and fixes for to_vec type-stability #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
approved these changes
Nov 23, 2020
|
Thanks, I made a few additions to do the same thing for the backwards pass. In general What is up with CI not running? |
|
ooooh
Looks like it's time for GitHub Actions. I'll open a PR. |
willtebbutt
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Nice one. Approved subject to CI passing once #119 has been merged.
|
rebase for new CI? |
|
CI is still pending review: #119 |
Not implemented for Julia 1.0
|
Unless someone objects, I'll merge this tomorrow. |
oxinabox
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117 as well as an issue with
to_vec(::Tuple)being type-unstable.