Add ChainRules integration test #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
approved these changes
Jan 10, 2021
There was a problem hiding this comment.
LGTM -- I guess this is copied directly from ChainRulesCore?
Would be good if @oxinabox could give the thumbs up before we merge though.
Yes that's right. |
oxinabox
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #132 (comment), this PR adds an integration test workflow for ChainRules (copied from the equivalent workflow used by ChainRulesCore). ChainRules extensively uses FiniteDifferences, and sometimes regressions here are not caught by our test suite but do cause ChainRules failures. This should help us catch these.