Fallback to_vec intended for structs
#140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 15, 2021 20:10
|
We don't mind the Nightly Julia tests failing right? It looks like there are some inference issues |
|
I don't think we do, but I'm not sure. IIRC the Julia nightlies have been failing for some time now on this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user has to define a
to_vecfunction for every new struct. This PR adds a fallback for structs.Thanks @willtebbutt for the implementation, I've just added a line to check against structs with no fieldnames (
Strings and singleton types for example). I couldn't think of anything else messing this up, but I'll have another think about it on Monday.