Switch to ReferenceTests.jl for testing output of format
#180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenJ
force-pushed
the
test/reference-tests
branch
5 times, most recently
from
ec6ce14 to
d9c9f7e
Compare
ReubenJ
force-pushed
the
test/reference-tests
branch
2 times, most recently
from
d9c9f7e to
850c5a2
Compare
ReubenJ
force-pushed
the
test/reference-tests
branch
2 times, most recently
from
5f63984 to
f58534a
Compare
Some tests only run for older Julia versions, these reference files are thus only generated for the first time when run with an older julia version. Run with julia@ - v1.11.6 - v1.6.7 - v1.3.1 - v1.12.2 - v1.1.1 Did not run on Windows, but "simulated" by replacing '/'s in the reference file with Windows' path separator: '\\'
ReubenJ
force-pushed
the
test/reference-tests
branch
from
f58534a to
cea5f6a
Compare
Contributor
Author
|
Updated with #179 (and updated those tests to use references). Should be ready for a 👀 @MichaelHatherly |
Member
|
Any idea what all the errors/warnings are about in https://github.com/JuliaDocs/DocStringExtensions.jl/actions/runs/19672474282/job/56344668284?pr=180#step:5:85? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #179, it would be a cleaner testing experience to compare the entire output of
formatto a reference output.ReferenceTests.jlimplements this workflow.I've switched all of the tests that were using some pattern of
occursinto check that some parts are present in the output to use the reference testing setup.A couple of nice things with this change:
formatis tested, not just some substring.