Graceful exit for transpose/adjoint on size 0 arrays #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Member
|
Isn't a |
Member
Author
|
Mostly to follow the style above in the function |
Member
|
Still, doesn't seem very legible to me. I'd prefer a simple |
maleadt
reviewed
Sep 2, 2025
maleadt
approved these changes
Sep 2, 2025
Member
Author
|
Is there a good way to test this only on CUDA? I think size 0 GPU arrays are not allowed on Metal/oneAPI? |
Member
|
Size 0 arrays should always work, or at least we promise they do (so we avoid hitting the allocator when unsupported by the underlying toolkit); this is a bug in Metal.jl. |
kshyatt
force-pushed
the
ksh/zero_dim
branch
from
31d4914 to
98654bb
Compare
Member
Author
|
Somehow I forgot to merge this? Going to do an update to make sure it still passes then set auto merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you try to take the
transpose!/adjoint!of an array with one or more dimensions of size 0, you'll get an integer division error in the launch configuration step. Not ideal.