GCN: Rewrite allocas from AS 0 to 5 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
reviewed
Aug 20, 2020
maleadt
requested changes
Aug 20, 2020
maleadt
reviewed
Aug 20, 2020
jpsamaroo
force-pushed
the
jps/gcn-workaround-allocas-2
branch
from
577dd1a to
312aae8
Compare
Member
|
Probably better remove the function and return attributes too? I can imagine these could fail to reconstruct too. |
Merged
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 60.50% 59.52% -0.98%
==========================================
Files 30 30
Lines 1585 1601 +16
==========================================
- Hits 959 953 -6
- Misses 626 648 +22
Continue to review full report at Codecov.
|
jpsamaroo
force-pushed
the
jps/gcn-workaround-allocas-2
branch
from
d1b4007 to
0fdc708
Compare
Member
Author
|
I'm testing this PR in #34, once I get that passing then I think this will be ready to go. |
jpsamaroo
force-pushed
the
jps/gcn-workaround-allocas-2
branch
from
0fdc708 to
82b29d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #47 with a superior, simpler approach.
Also disables parameter attribute copying in
only_entry=true, because of JuliaLLVM/LLVM.jl#186