Fix crosses and overlaps to follow geom relations convention
#360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated boilerplate in `common.jl` expects functions to use underscore-prefixed internal methods (e.g., `_crosses`, `_overlaps`) for trait-based dispatch, while the public API calls these internal methods. Updated both functions to follow this pattern, ensuring proper handling of Features, Extents, and table rows.
Ensures that `crosses` and `overlaps` work correctly with: - Features wrapping geometries - NamedTuples with geometry fields - Mixed combinations of Features and raw geometries These tests verify that the underscore-prefixed internal methods properly handle the boilerplate in `common.jl` for Feature unwrapping.
Adds tests to cover previously untested code paths: - Line × Line overlaps (GI.LineTrait) - MultiPolygon × MultiPolygon overlaps These tests ensure the new `_overlaps` methods are properly exercised.
rafaqz
approved these changes
Nov 9, 2025
rafaqz
deleted the
claude/fix-geom-relations-functions-011CUqXLzgLiff1NSrSXCizQ
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated boilerplate in
common.jlexpects functions to use underscore-prefixed internal methods (e.g.,_crosses,_overlaps) for trait-based dispatch, while the public API calls these internal methods. Updated both functions to follow this pattern, ensuring proper handling of Features, Extents, and table rows.