Skip to content

Fix incompatibility with recent Meshes changes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Aug 10, 2024
Merged

Fix incompatibility with recent Meshes changes #42

merged 44 commits into from
Aug 10, 2024

Conversation

@mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Aug 10, 2024

Implements updates required for compatibility with recent Meshes.j/CRS changes.

mikeingold added 30 commits July 29, 2024 12:18
@mikeingold
Add branch TODO and update Meshes compat
8d5f0df
@mikeingold
Remove some unnecessary param types
204673f
@mikeingold
Restructure such that T is an optional first argument
5dfa6e5
@mikeingold
Bump version and uodate readme with status
8924d11
@mikeingold
Replace T of DataType param with FP of Type T
6f9cc97
@mikeingold
Remove checking for MethodError with user function
2d867d9
@mikeingold
Remove more MethodError checks
33ede6e
@mikeingold
Continue implementing new structure
a47b3f6
@mikeingold
Reorganize arguments (optional FP is now last), various bugfixes
2b8cd23
@mikeingold
Update tests
171c1c3
@mikeingold
Bugfixes
ad6c0c2
@mikeingold
Fix Box parameterization
99f84a8
@mikeingold
Fix Geometry parameterization
a432679
@mikeingold
Bugfixes
4a73d63
@mikeingold
Bugfix in Plane vector normalization
bd8677c
@mikeingold
Bugfixes in Line and Ray vector normalization
6e7e68d
@mikeingold
Add shim code to handle Unitful types in HCubature methods
2d90d1d
@mikeingold
Bugfix missing using statement
5dffc92
@mikeingold
Bugfix typo
9da38d2
@mikeingold
Bugfix for broadcastable f returns
60cdc58
@mikeingold
More broadcasting required
9cb210b
@mikeingold
Update HCubature line and volume integrals
9e23058
@mikeingold
Implement new HCubature technique for BezierCurve specialization
d5b8762
@mikeingold
Update CylinderSurface to outsource disk integrations
4229b18
@mikeingold
Update HCubature methods with more generalized parametric coord gener…
1372ed8 
…ators
@mikeingold
Make a generic HCubature method and point 1D integrals to it
5c70ff3
@mikeingold
Remove old commented out code and reorganize
4749daf
@mikeingold
Update integral function signatures, split alias functions into new file
f27e393
@mikeingold
Convert all _integral_nd methods to point toward new generalized version
0b9d123
@mikeingold
Bugfix to method signatures
9e8d385
@mikeingold
Copy link
Collaborator Author

mikeingold commented Aug 10, 2024

Changes:

  • Established compatibility with recent Meshes.jl versions (0.43+) that implemented CRS changes
  • Adds direct dependencies on CRS and Unitful for handling of new Meshes.jl type structures
  • Added an optional floating-point precision type argument, e.g. integral(f, geometry, settings, T)
  • Lots of internal restructuring
  • Add support for integration of CylinderSurfaces with HAdaptiveCubature algorithm

Longer term outlook (document as TODO actions in GitHub Issues?)

  • Evaluate Zygote for AD Jacobians
  • Implement generalized GaussLegendre method

@mikeingold mikeingold merged commit a800275 into main Aug 10, 2024
@mikeingold mikeingold deleted the crs branch August 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikeingold