Skip to content

Conversation

@JoshuaLampert
Copy link
Member

Now that we have CI and coverage running, we can add the badges indicating the code coverage and linking to the respective pages to the README.
(This is also meant as a test PR to see if CI runs in a PR now)

@JoshuaLampert
Copy link
Member Author

Good news: GitHub Action runs.
Bad news: For some reason it only runs the spell checker, but nothing else.

@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Aug 16, 2024

I see. CI doesn't run because it's not supposed to run 😅

@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Aug 16, 2024

With changes to the source it actually runs. So everything looks fine now 👍. It really seems that GitHub Actions doesn't run in a PR that creates the workflow and which comes from a fork.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@JoshuaLampert
Copy link
Member Author

And codecov comment also works 🎉. So I think we are all set.

@mikeingold mikeingold merged commit d42407c into JuliaGeometry:main Aug 16, 2024
@JoshuaLampert JoshuaLampert deleted the badges-coverage branch August 16, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants