Skip to content

Conversation

@mikeingold
Copy link
Collaborator

@mikeingold mikeingold commented Sep 7, 2024

Completed:

  • Began restructure of unit tests
    • Increased Codecov-reported test coverage from 77% to 84%
  • Discovered and fixed bug - incorrect default IntegrationAlgorithm for methods surfaceintegral(f, geometry) and volumeintegral(f, geometry)
  • Fixed tests for integrating FrustumSurface and added them to official support

@codecov
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (50268f4) to head (ad2fbe9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   76.77%   83.85%   +7.08%     
==========================================
  Files           7        7              
  Lines         353      353              
==========================================
+ Hits          271      296      +25     
+ Misses         82       57      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold mikeingold marked this pull request as ready for review September 8, 2024 16:03
@mikeingold mikeingold merged commit 1b9258e into main Sep 8, 2024
@mikeingold mikeingold deleted the restructure-tests branch September 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants