Skip to content

Conversation

@JoshuaLampert
Copy link
Member

I noticed that there is no tag bot used, i.e. you manually create a tag after registering a new version of the package. The tag bot is widely used for Julia packages to automatically create a new tag once the register PR in General is merged. This way consistency between the registry in General and the actual registered versions is guaranteed and you don't need to manually create a new tag. I think it's generally considered good practice to have tag bot running and thus it would be nice to also have it here.
See https://github.com/JuliaRegistries/TagBot.

@codecov
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (1b9258e) to head (d718ef4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files           7        7           
  Lines         353      353           
=======================================
  Hits          296      296           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold
Copy link
Collaborator

Thanks again, @JoshuaLampert!

@mikeingold mikeingold merged commit 46d1c4a into main Sep 9, 2024
@mikeingold mikeingold deleted the tagbot branch September 9, 2024 11:06
@mikeingold
Copy link
Collaborator

@JoshuaLampert What actions are supposed to trigger TagBot to generate a tag and Release? I was thinking it would detect a version bump in the Project.toml as the trigger, but their repo README is a little unclear to me in that regard.

@JoshuaLampert
Copy link
Member Author

You still need to call the JuliaRegistrator by commenting on the last commit, which bumped the package version as you did before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants