add isfinite method for Bool-based grays #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
Mar 3, 2017
Member
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
Looks good. If you don't want to go the more ambitious route I outlined, that's fine. No matter what, this needs a test, and it would be better if isinf and isnan were also supported.
| min(a::AbstractGray, b::Number) = min(promote(a,b)...) | ||
|
|
||
| isfinite{T<:AbstractFloat}(c::AbstractGray{T}) = isfinite(gray(c)) | ||
| isfinite{T<:Bool}(c::AbstractGray{T}) = isfinite(gray(c)) |
Member
There was a problem hiding this comment.
I wonder if we could just define two methods,
isfinite{T<:Normed}(c::Colorant{T}) = true
isfinite(c::Colorant) = reducec(&, isfinite, c)where reducec would be defined similarly to mapc. Obviously the same would apply for isnan, isinf.
This was referenced Mar 27, 2017
Member
|
I decided to go with the more general solution in #73. Thanks for reporting the problem! |
Author
|
Sure, and your solution looks much better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem mentioned in JuliaGraphics/ColorTypes#76. Adds a new
isfinitedefinition forColorTypes.Gray{Bool}instances, which complements the existing definitions for float-based grays.