Use Topological Sorting for function typedefs. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Feb 16, 2019
jorickert
changed the title
jorickert
changed the title
vtjnash
reviewed
Mar 11, 2019
vtjnash
requested changes
Mar 25, 2019
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
code from incompatible license needs to be replaced
This prevents errors caused by a wrong ordering of functions which take a function pointer as argument
Contributor
Author
|
I changed the sorting so that it uses a DFS based sorting and does not use third party code anymore. |
vtjnash
approved these changes
Apr 2, 2019
Member
|
Excellent, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents errors caused by a wrong ordering of functions which take a function pointer as argument