added warning in case of unset JULIA_COPY_STACKS variable #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviks
reviewed
Feb 10, 2020
src/jvm.jl
Outdated
| addOpts(s::String) = isloaded() ? @warn("JVM already initialised. This call has no effect") : push!(opts, s) | ||
|
|
||
| function init() | ||
| if get(ENV, "JULIA_COPY_STACKS", "") ∉ ("1", "yes") |
There was a problem hiding this comment.
If we are doing this, I'd like this to be a little more sophisticated wrt Julia versions. JULIA_COPY_STACKS is not needed on v1.0 and does not work on v1.1 or v1.2
There was a problem hiding this comment.
I've added a version number check.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems pretty silly of us not to have had this already.
Current behavior might be pretty bewildering to anyone who's not constantly reading Julia discourse or Slack, which is not at all ideal.
I also took this opportunity to delete the long since deprecated
REQUIREfile.Currently the behavior with unset
JULIA_COPY_STACKSis so bad that perhaps we should even consider throwing an explicit exception here.