fix Pair usage for ordereddict #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Base didn't actually start returning Pairs until pretty recently, even though the change to using Pairs everywhere else happened at v"0.4.0-dev+980".
This is probably okay, though--I doubt people are depending on this, and I doubt this would break code even if they were.
(Comments to the contrary welcome.)
Author
|
rebased. I removed the fix for the 0 in Intset warning, I'll better leave that for @StephenVavasis to handle. |
kmsquire
added a commit
that referenced
this pull request
Aug 9, 2015
fix Pair usage for ordereddict
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
collectreturn an array ofPairs, fixes unit tests.Fixed(not necessary after rebase)IntSetdeprectation warning forstatus()ofSortedDict.