Serialize & deserialize hashdicts in Julia 0.4 #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielArndt
changed the title
DanielArndt
force-pushed
the
serialize-deserialize-hashdicts-0.4
branch
from
89ea86a to
f813a7e
Compare
Collaborator
Author
|
@kmsquire thoughts? |
Member
|
LGTM. Sorry, my Julia time has been almost non-existent recently. |
kmsquire
added a commit
that referenced
this pull request
Nov 6, 2015
…cts-0.4 Serialize & deserialize hashdicts in Julia 0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
writechanged a bit in Julia 0.4, and usingSerState(ie.Base.Serializer.SerializationState) directly doesn't work.s.ioworks in 0.4 but wouldn't be backwards compatible with Julia 0.3.Using the
serializemethod provided in the Julia distribution will allow the base library to make the appropriate call.