RFC: change type to hide implementation #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmsquire
force-pushed
the
kms/ac/hide_stack_queue_implementation
branch
from
5952118 to
8d582cf
Compare
kmsquire
force-pushed
the
kms/ac/hide_stack_queue_implementation
branch
from
8d582cf to
ff2479d
Compare
Collaborator
|
LGTM, I was always a little curious why the type was exposed like that. |
Contributor
|
+1 a related change is adding eltype for many types, I have a branch but will rebase off this once merged. |
kmsquire
added a commit
that referenced
this pull request
Jan 14, 2016
…entation RFC: change type to hide implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #98, which I was too slow to merge before. It's a minor change, and if there's reason not to do this, it can easily be reverted later. But it's a small step in the right direction to cleaning up
StackandQueue(andDeque) types.(Original PR from @andrewcooke; he still owns the commit.)