Skip to content

Conversation

@kmsquire
Copy link
Member

Cleaning up error functions.

In cases where the correct exception seemed ambiguous (e.g., pop! on an empty Deque), I followed conventions in Base.

@kmsquire
Copy link
Member Author

Will merge tomorrow if there are no comments.

@DanielArndt
Copy link
Collaborator

@kmsquire really quick rebase needed here (there's a small conflict with you adding a Base.Test import, and pr #172 removed the imports) which I can do if you wouldn't mind that I force push over your branch (Or if you have a few minutes quickly do it yourself).

@kmsquire
Copy link
Member Author

If you wouldn't mind doing that and merging, that would be great!

@DanielArndt DanielArndt force-pushed the kms/remove_error_calls branch from 77745a8 to cfcb814 Compare January 27, 2016 13:48
DanielArndt added a commit that referenced this pull request Jan 27, 2016
RFC: Use "throw" with a specific exception instead of "error()"
@DanielArndt DanielArndt merged commit 911a4af into master Jan 27, 2016
@DanielArndt DanielArndt deleted the kms/remove_error_calls branch January 27, 2016 14:13
@kmsquire
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants