-
Notifications
You must be signed in to change notification settings - Fork 262
move imports to runtests #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move imports to runtests #172
Conversation
|
Actually, I would prefer to leave the imports at the top of each file. Without that, it's not possible to run individual tests from the command line--you'd have to run them all, and that's slightly annoying during development. Also, it doesn't really hurt anything--if a file has already been imported, the second import is almost a no-op. (But I really, really do appreciate trying to clean things up--thanks!) |
|
@kmsquire one thing we could do to alleviate that is to do what the |
|
Sure, that would be fine. The main Julia repo does something similar. |
|
I like the idea of being able to run tests in groups and individually (it can really cut down turnaround time if you're doing a little TDD or "test backed re-factoring" (TBR?), but some of the test files don't currently run independently. |
|
@DanielArndt, would you be okay with @rawls238 proposed solution of an extra command line parameter? |
|
Certainly. I think another feature that could possibly extend the model QuantEcon uses is to put individual tests in functions, and add the ability to run tests individually (instead of entire files). We use a model similar to what I describe internally, and I've been meaning to look at where base Julia is headed for tests, and see if there was a benefit to extracting some of that out. |
2785cc2 to
0d75294
Compare
|
@DanielArndt that seems interesting to implement, but I think beyond the scope of this PR. Certainly something that would be nice to have. Let me know if you guys are good with merging this |
|
LGTM! Feel free to merge. |
@kmsquire
this cleans up the tests a bit so that most of the imports are done in
runtestsinstead of duplicated across test files