Skip to content

Conversation

@rawls238
Copy link
Contributor

@rawls238 rawls238 commented Feb 8, 2016

@kmsquire @DanielArndt

Let me know if you guys think any changes should be made to the docs before merging this in:

http://datastructuresjl.readthedocs.org/en/latest

@kmsquire I'm not sure if the readthedocs github webhooks are properly set up so that the docs can be updated (I don't have the github permissions to look in settings). Could you confirm that they're set / if they're not set them?

@rawls238 rawls238 force-pushed the guy_docs_instead_of_readme branch from 313cee6 to 0c0d89a Compare February 8, 2016 15:16
@rawls238 rawls238 force-pushed the guy_docs_instead_of_readme branch from e61ce87 to 43ec8f3 Compare February 8, 2016 15:17
@DanielArndt
Copy link
Collaborator

Looks great!

One thing I noticed is that when viewing the documentation, in the left-side menu it appears that "Overview of Sorted Containers" is on the same level as everything below it (ie. "Tokens for Sorted Containers", which is actually a sub-section).

Not sure if this is an issue with the theme, or the way it is contructed.

@kmsquire
Copy link
Member

kmsquire commented Feb 8, 2016

@rawls238 I added you as a maintainer on DataStructures.

@DanielArndt, @StephenVavasis, if you have or create an account on ReadTheDocs, I can add you as well.

@kmsquire
Copy link
Member

kmsquire commented Feb 8, 2016

Actually, ignore that last comment: that requires someone who's an owner on JuliaLang, and I'm not, so I don't have access either.

@kmsquire
Copy link
Member

kmsquire commented Feb 8, 2016

@StefanKarpinski @ViralBShah can one of you modify the permissions on RTD to allow myself and @rawls238 to maintain DataStructures.jl there?

@kmsquire
Copy link
Member

kmsquire commented Feb 8, 2016

Okay, nevermind. I do actually have access. Sorry for the noise. ( @rawls238, you should as well.)

@DanielArndt
Copy link
Collaborator

I created an account and linked it to my github. Is there anything else I need to do?

@rawls238
Copy link
Contributor Author

rawls238 commented Feb 8, 2016

@DanielArndt that's valid. I think that has to do with how I set up the index file, I'll try to change that around before merging this in

@rawls238
Copy link
Contributor Author

rawls238 commented Feb 9, 2016

@DanielArndt fixed the issue with sorted containers

rawls238 pushed a commit that referenced this pull request Feb 9, 2016
replace README docs with link to readthedocs
@rawls238 rawls238 merged commit c6ca7c0 into master Feb 9, 2016
@rawls238 rawls238 deleted the guy_docs_instead_of_readme branch February 9, 2016 01:48
@hayd
Copy link
Contributor

hayd commented Feb 9, 2016

As I commented in the closed #173 this feels like the wrong direction. Nothing in DataStructures has any ? help (which will have to be markdown at some point).

I guess I should do rather than complain...

@DanielArndt
Copy link
Collaborator

@hayd Are you suggesting the best thing to do would be to move all this information to the function definitions, inline as markdown, and wait for the Julia documentation system to be able to generate the documentation?

Sorry if I'm being a little dense, I'm not entirely familiar with the state of the documentation system in the language. I know that base Julia has a lot of documentation in rst/sphinx format. Is it moving away from that entirely in favour of documentation generated from inline comments? As far as I remember, I had to change the documentation in order to generate the inline comments in base (which seems backwards).

@hayd
Copy link
Contributor

hayd commented Feb 9, 2016

yes, doc generation will be ready soon (next few weeks hopefully). yes, base is moving away from rst entirely. Moving to markdown would make the transition (to inline docstrings and generated online docs) for DataStructures much easier.

@rawls238
Copy link
Contributor Author

rawls238 commented Feb 9, 2016

sweet, we could try running the doc files through pandoc to convert them to markdown.

@StefanKarpinski
Copy link
Contributor

I'm not sure if it's helpful or not, but https://github.com/JuliaLang/julia/tree/sk/markdown implements a Sphinx backend that generates Markdown that's a speculative version of JuliaMarkdown.

@kmsquire
Copy link
Member

Just pinging @StephenVavasis, who previously explicitly converted the README file to rst (by hand, I believe), because he was concerned about the expressiveness of markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants