-
Notifications
You must be signed in to change notification settings - Fork 262
replace README docs with link to readthedocs #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
313cee6 to
0c0d89a
Compare
e61ce87 to
43ec8f3
Compare
|
Looks great! One thing I noticed is that when viewing the documentation, in the left-side menu it appears that "Overview of Sorted Containers" is on the same level as everything below it (ie. "Tokens for Sorted Containers", which is actually a sub-section). Not sure if this is an issue with the theme, or the way it is contructed. |
|
@rawls238 I added you as a maintainer on DataStructures. @DanielArndt, @StephenVavasis, if you have or create an account on ReadTheDocs, I can add you as well. |
|
Actually, ignore that last comment: that requires someone who's an owner on JuliaLang, and I'm not, so I don't have access either. |
|
@StefanKarpinski @ViralBShah can one of you modify the permissions on RTD to allow myself and @rawls238 to maintain DataStructures.jl there? |
|
Okay, nevermind. I do actually have access. Sorry for the noise. ( @rawls238, you should as well.) |
|
I created an account and linked it to my github. Is there anything else I need to do? |
|
@DanielArndt that's valid. I think that has to do with how I set up the index file, I'll try to change that around before merging this in |
|
@DanielArndt fixed the issue with sorted containers |
replace README docs with link to readthedocs
|
As I commented in the closed #173 this feels like the wrong direction. Nothing in DataStructures has any ? help (which will have to be markdown at some point). I guess I should do rather than complain... |
|
@hayd Are you suggesting the best thing to do would be to move all this information to the function definitions, inline as markdown, and wait for the Julia documentation system to be able to generate the documentation? Sorry if I'm being a little dense, I'm not entirely familiar with the state of the documentation system in the language. I know that base Julia has a lot of documentation in |
|
yes, doc generation will be ready soon (next few weeks hopefully). yes, base is moving away from rst entirely. Moving to markdown would make the transition (to inline docstrings and generated online docs) for DataStructures much easier. |
|
sweet, we could try running the doc files through pandoc to convert them to markdown. |
|
I'm not sure if it's helpful or not, but https://github.com/JuliaLang/julia/tree/sk/markdown implements a Sphinx backend that generates Markdown that's a speculative version of JuliaMarkdown. |
|
Just pinging @StephenVavasis, who previously explicitly converted the |
@kmsquire @DanielArndt
Let me know if you guys think any changes should be made to the docs before merging this in:
http://datastructuresjl.readthedocs.org/en/latest
@kmsquire I'm not sure if the
readthedocsgithub webhooks are properly set up so that the docs can be updated (I don't have the github permissions to look in settings). Could you confirm that they're set / if they're not set them?