Added function ordtype for SortedDict, SortedMultiDict and SortedSet. #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function returns the type of the ordering parameter. Fixes JuliaCollections#226
Current coverage is 92.23% (diff: 100%)@@ master #230 diff @@
==========================================
Files 28 29 +1
Lines 2338 2357 +19
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2156 2174 +18
- Misses 182 183 +1
Partials 0 0
|
Contributor
|
this seems reasonable to me, restarted the builds to see if they'll pass. If they do, I'll merge this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function returns the type of the ordering parameter. Fixes #226