RFC: Deprecate or fix old/broken DefaultDict constructors #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DictandOrderedDictconstructors have changed, andDefaultDict/DefaultOrderedDicthaven't kept up.The changes:
Dict(KeyType, ValType) => Dict{KeyType, ValType}()
Dict(ks, vs) is deprectated
This deprecates working versions of these from DefaultDict
and friends, and fixes broken calls which attempt to
use these old constructors.