Add warning on unordered to ordered conversion. Fixes #216 #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstjean
changed the title
Current coverage is 95.85% (diff: 71.42%)@@ master #237 diff @@
==========================================
Files 30 30
Lines 2213 2220 +7
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2123 2128 +5
- Misses 90 92 +2
Partials 0 0
|
kmsquire
approved these changes
Jan 11, 2017
Member
|
@cstjean, sorry for the delay on this, but would you be able to add some tests? |
Member
|
(Also, there is a minor conflict.) |
Contributor
Author
|
Can I test the warnings? Or do you mean to make sure that |
Member
|
Just testing |
cstjean
force-pushed
the
pull-request/483460f4
branch
from
483460f to
bb1533b
Compare
cstjean
force-pushed
the
pull-request/483460f4
branch
from
bb1533b to
eae3098
Compare
Contributor
Author
|
Tested and rebased. |
Member
|
Thanks! |
Member
|
For testing the deprecation see JuliaLang/julia#20348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to match the tone from Base, but please let me know if anything sounds off.