Skip to content

Conversation

@Keno
Copy link
Member

@Keno Keno commented Nov 4, 2025

When JULIA_DEPOT_PATH is set, the stdlib depots might not be in DEPOT_PATH. However, because the test does not inherit the env var and instead sets it to something custom, the child processes will get the default. To make sure the tests work properly, just reach into base and query the right values.

When JULIA_DEPOT_PATH is set, the stdlib depots might not be in DEPOT_PATH. However, because the test does not inherit the env var and instead sets it to something custom, the child processes will get the default. To make sure the tests work properly, just reach into base and query the right values.
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.34%. Comparing base (661112e) to head (a80a88b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   79.38%   79.34%   -0.05%     
==========================================
  Files          10       10              
  Lines        1955     1951       -4     
==========================================
- Hits         1552     1548       -4     
  Misses        403      403              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JamesWrigley
Copy link
Member

Not sure I follow how this could break, are you saying that if JULIA_DEPOT_PATH is set to something that doesn't include the stdlib depots before ] test is run then the test process running test/distributed_exec.jl will not see the stdlib depots at all and thus cause the tests to fail?

@Keno
Copy link
Member Author

Keno commented Nov 4, 2025

Yes

Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JamesWrigley JamesWrigley merged commit cd92195 into master Nov 4, 2025
7 of 8 checks passed
@JamesWrigley JamesWrigley deleted the kf/fixdepotset branch November 4, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants