Skip to content

Add ignore_errors keyword to main parser API #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Add ignore_errors keyword to main parser API #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/parser_api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ function parse!(::Type{TreeType}, io::IO;
end

function _parse(rule::Symbol, need_eof::Bool, ::Type{T}, text, index=1; version=VERSION,
ignore_trivia=true, filename=nothing, ignore_warnings=false) where {T}
ignore_trivia=true, filename=nothing, ignore_errors=false,
ignore_warnings=ignore_errors) where {T}
stream = ParseStream(text, index; version=version)
if ignore_trivia && rule != :toplevel
bump_trivia(stream, skip_newlines=true)
Expand All @@ -85,7 +86,8 @@ function _parse(rule::Symbol, need_eof::Bool, ::Type{T}, text, index=1; version=
emit_diagnostic(stream, error="unexpected text after parsing $rule")
end
end
if any_error(stream.diagnostics) || (!ignore_warnings && !isempty(stream.diagnostics))
if (!ignore_errors && any_error(stream.diagnostics)) ||
(!ignore_warnings && !isempty(stream.diagnostics))
throw(ParseError(stream, filename=filename))
end
# TODO: Figure out a more satisfying solution to the wrap_toplevel_as_kind
Expand Down
12 changes: 12 additions & 0 deletions test/parser_api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,16 @@
@test parseatom(Expr, SubString("x+y"), 1) == (:x, 2)
@test parseatom(Expr, SubString("x+y"), 3) == (:y, 4)
end

@testset "error/warning handling" begin
# ignore_warnings
parse_sexpr(s;kws...) = sprint(show, MIME("text/x.sexpression"), parse(SyntaxNode, s; kws...))
@test_throws JuliaSyntax.ParseError parse_sexpr("try finally catch ex end")
@test parse_sexpr("try finally catch ex end", ignore_warnings=true) ==
"(try_finally_catch (block) false false false (block) ex (block))"
# ignore_errors
@test_throws JuliaSyntax.ParseError parse_sexpr("[a; b, c]")
@test_throws JuliaSyntax.ParseError parse_sexpr("[a; b, c]", ignore_warnings=true)
@test parse_sexpr("[a; b, c]", ignore_errors=true) == "(vcat a b (error-t) c)"
end
end