Skip to content

use === for comparisons to nothing #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonDanisch merged 2 commits into from
Feb 1, 2019
Merged

use === for comparisons to nothing #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f535cf
use === for comparisons to nothing
musm Jan 31, 2019
fe7c103
Update system_image.jl
musm Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/snooping.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function snoop(package, tomlpath, snoopfile, outputfile, reuse = false)
using Pkg, PackageCompiler
"""

if tomlpath != nothing
if tomlpath !== nothing
command *= """
Pkg.activate($(repr(tomlpath)))
Pkg.instantiate()
Expand All @@ -31,11 +31,11 @@ function snoop(package, tomlpath, snoopfile, outputfile, reuse = false)
run_julia(command, compile = "all", O = 0, g = 1, trace_compile = tmp_file)
end
used_packages = Set{String}() # e.g. from test/REQUIRE
if package != nothing
if package !== nothing
push!(used_packages, string(package))
end
usings = ""
if tomlpath != nothing
if tomlpath !== nothing
# add toml packages, in case extract_used_packages misses a package
deps = get(TOML.parsefile(tomlpath), "deps", Dict{String, Any}())
union!(used_packages, string.(keys(deps)))
Expand Down
2 changes: 1 addition & 1 deletion src/system_image.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function compile_system_image(sysimg_path, cpu_target = nothing; debug = false)
# At some point, I will need to understand build_object a bit better before doing that move, though!
julia_cmd = Base.julia_cmd()
julia = julia_cmd.exec[1]
cpu_target = if cpu_target == nothing
cpu_target = if cpu_target === nothing
replace(julia_cmd.exec[2], "-C" => "")
else
cpu_target
Expand Down