Make qrfact and qrfact! type-stable #11240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you also add some |
Member
Author
|
Good idea. Done. |
andreasnoack
added a commit
that referenced
this pull request
May 12, 2015
Make qrfact and qrfact! type-stable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in http://stackoverflow.com/questions/30155465/fast-tensor-initialisation-in-julia, qr factorization is not type-stable. This fixes part of the problem, but it's not enough on its own to make
qrtype-stable (even if you supply aVal{true}). I suspect it comes down to theF[:Q]syntax. This is just drive-by bugfixing, so I didn't make any difficult decisions.