Carry LLVM patch that limits llvm-config flags #32400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an LLVM 6.0/7.0 backport of a patch that changes which flags llvm-config passes. This shouldn't matter much for most uses cases, but it's useful for two reasons: 1) It makes the behavior of llvm-config consistent between all the LLVM versions we support, making it easier for find any problems with our Makefile. 2) It prevents any flags meant for LLVM only from creeping into the build of our .cpp files (there isn't usually a need for this, but I needed to be able to do this when trying to target wasm)
staticfloat
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an LLVM 6.0/7.0 backport of a patch that changes which flags
llvm-config passes. This shouldn't matter much for most uses cases,
but it's useful for two reasons:
versions we support, making it easier for find any problems with our
Makefile.
of our .cpp files (there isn't usually a need for this, but I needed
to be able to do this when trying to target wasm)