lowering,new: improve implementation robustness #32404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vtjnash
commented
Jun 24, 2019
vtjnash
commented
- move implementation of splatnew into lowering instead of dispatch (given the current definition of splatnew)
- use field indexes with fieldtype instead of names
- use fieldtype in most cases, instead of copying expression tree
- explicit syntax error for too many type parameters on new (instead of deferring to the runtime apply_type error)
- move implementation of splatnew into lowering instead of dispatch (given the current definition of splatnew) - use field indexes with fieldtype instead of names - use fieldtype in most cases, instead of copying expression tree - explicit syntax error for too many type parameters on new (instead of deferring to the runtime apply_type error)
vtjnash
force-pushed
the
jn/new-lowering-simplify
branch
from
b7ddd6b to
c054ff5
Compare
Member
That's fine, but I'm curious what the motivation for it is? |
Member
Author
|
Just simpler. In the backend, we’ll try to optimize to an integer—so seemed like we might as well start there. |
| (if (equal? fty '(core Any)) | ||
| val | ||
| `(call (top convert) | ||
| ,(if (and (equal? type-params params) (memq fty params) (memq fty sparams)) |
Member
There was a problem hiding this comment.
I don't think the (memq fty sparams) check is necessary.
Member
Author
There was a problem hiding this comment.
I actually added a test for that. This is stricter than necessary (we only really need to show that duplicating fty won't have side-effects here—or we needed to introduce an ssavalue), but it seems like not a very common case anyways.
JeffBezanson
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.