arrayunset: micro-optimization for performance #32405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Jun 24, 2019
quinnj
reviewed
Jun 24, 2019
| isbitsunion(u::Union) = (@_pure_meta; ccall(:jl_array_store_unboxed, Cint, (Any,), u) != Cint(0)) | ||
| isbitsunion(x) = false | ||
|
|
||
| isptrelement(t::Type) = (@_pure_meta; ccall(:jl_array_store_unboxed, Cint, (Any,), t) == Cint(0)) |
Member
There was a problem hiding this comment.
we already define this here, so maybe we should consolidate.
Member
Author
There was a problem hiding this comment.
It's not quite the same, since the other query is related to this query by the formula isbitsunion(u) = u isa Union && isptrelement(u)
Member
There was a problem hiding this comment.
Right; I was mainly pointing out that maybe we should define a single ccall definition for this (and have isbitsunion call that), just to minimize the need to update things in two places if jl_array_store_unboxed ever changes.
JeffBezanson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.