Skip to content

alloc profiler: add compat note to docstring #44100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

alloc profiler: add compat note to docstring #44100

merged 1 commit into from
Feb 10, 2022

Conversation

@vilterp
Copy link
Contributor

@vilterp vilterp commented Feb 9, 2022 •
edited
Loading

Note that the alloc profiler was only added in 1.8.

Also, put a box around the note about missing types.

cc @NHDaly

Sacha0
Sacha0 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pete! :)

NHDaly
NHDaly approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks pete!

fredrikekre
fredrikekre reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pete! :)

@fredrikekre fredrikekre merged commit aae68a5 into JuliaLang:master Feb 10, 2022
@NHDaly NHDaly deleted the pv-alloc-prof-compat-warning branch February 10, 2022 17:04
@NHDaly NHDaly mentioned this pull request Feb 10, 2022
Closed
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
@vilterp @antoine-levitt
alloc profiler: add compat note to docstring (JuliaLang#44100)
8057173
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vilterp @LilithHafner
alloc profiler: add compat note to docstring (JuliaLang#44100)
0023104
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vilterp @LilithHafner
alloc profiler: add compat note to docstring (JuliaLang#44100)
3c14219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@NHDaly NHDaly NHDaly approved these changes

+1 more reviewer

@Sacha0 Sacha0 Sacha0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vilterp @NHDaly @Sacha0 @fredrikekre