Fix negativity check in codegen

[yuyichao]

The source for both are signed.

[topolarity]

Isn't there a warning we can enable for this?

[giordano]

This PR broke stacktrace tests everywhere https://buildkite.com/julialang/julia-master/builds/51722#019a272e-758b-421e-b765-4887a01eb843/1157-1900

Error in testset stacktraces:
Test Failed at /cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/stacktraces.jl:251
  Expression: contains(str, "[5] \e[0m\e[1mcollect_to!\e[22m\e[0m\e[1m(\e[22m\e[90mdest\e[39m::\e[0mVector\e[90m{…}\e[39m, \e[90mitr\e[39m::\e[0mBase.Generator\e[90m{…}\e[39m, \e[90moffs\e[39m::\e[0m$(Int), \e[90mst\e[39m::\e[0m$(Int)\e[0m\e[1m)\e[22m\n")
   Evaluated: contains("\nStacktrace:\n  [1] \e[0m\e[1mthrow_complex_domainerror\e[22m\e[0m\e[1m(\e[22m\e[90mf\e[39m::\e[0mSymbol, \e[90mx\e[39m::\e[0mFloat64\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[90mBase.Math\e[39m \e[90m./\e[39m\e[90m\e[4mmath.jl:33\e[24m\e[39m\n  [2] \e[0m\e[1m_setindex!\e[22m\n \e[90m   @\e[39m \e[90m./\e[39m\e[90m\e[4marray.jl:1024\e[24m\e[39m\e[90m [inlined]\e[39m\n  [3] \e[0m\e[1msetindex!\e[22m\n \e[90m   @\e[39m \e[90m./\e[39m\e[90m\e[4marray.jl:1020\e[24m\e[39m\e[90m [inlined]\e[39m\n  [4] \e[0m\e[1mcollect_to!\e[22m\e[0m\e[1m(\e[22m\e[90mdest\e[39m::\e[0mVector\e[90m{…}\e[39m, \e[90mitr\e[39m::\e[0mBase.Generator\e[90m{…}\e[39m, \e[90moffs\e[39m::\e[0mInt64, \e[90mst\e[39m::\e[0mInt64\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[90mBase\e[39m \e[90m./\e[39m\e[90m\e[4marray.jl:890\e[24m\e[39m\n  [5] \e[0m\e[1mcollect_to_with_first!\e[22m\n \e[90m   @\e[39m \e[90m./\e[39m\e[90m\e[4marray.jl:864\e[24m\e[39m\e[90m [inlined]\e[39m\n  [6] \e[0m\e[1mcollect\e[22m\e[0m\e[1m(\e[22m\e[90mitr\e[39m::\e[0mBase.Generator\e[90m{Base.ReinterpretArray{…}, Main.Test17Main_stacktraces.var\"#sqrteach##1#sqrteach##2\"}\e[39m\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[90mBase\e[39m \e[90m./\e[39m\e[90m\e[4marray.jl:838\e[24m\e[39m\n  [7] \e[0m\e[1m(::Main.Test17Main_stacktraces.var\"#sqrteach#sqrteach##0\")\e[22m\e[0m\e[1m(\e[22m\e[90ma\e[39m::\e[0mBase.ReinterpretArray\e[90m{…}\e[39m\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[32mMain.Test17Main_stacktraces\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mstacktraces.jl:244\e[24m\e[39m\n  [8] top-level scope\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mstacktraces.jl:213\e[24m\e[39m\n  [9] \e[0m\e[1mmacro expansion\e[22m\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/stdlib/v1.13/Test/src/\e[39m\e[90m\e[4mTest.jl:1961\e[24m\e[39m\e[90m [inlined]\e[39m\n [10] \e[0m\e[1mmacro expansion\e[22m\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mstacktraces.jl:246\e[24m\e[39m\e[90m [inlined]\e[39m\n [11] \e[0m\e[1minclude\e[22m\e[0m\e[1m(\e[22m\e[90mmod\e[39m::\e[0mModule, \e[90m_path\e[39m::\e[0mString\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[90mBase\e[39m \e[90m./\e[39m\e[90m\e[4mBase.jl:309\e[24m\e[39m\n [12] \e[0m\e[1mmacro expansion\e[22m\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mtestdefs.jl:35\e[24m\e[39m\e[90m [inlined]\e[39m\n [13] \e[0m\e[1mmacro expansion\e[22m\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/stdlib/v1.13/Test/src/\e[39m\e[90m\e[4mTest.jl:1961\e[24m\e[39m\e[90m [inlined]\e[39m\n [14] \e[0m\e[1mmacro expansion\e[22m\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mtestdefs.jl:27\e[24m\e[39m\e[90m [inlined]\e[39m\n [15] \e[0m\e[1mmacro expansion\e[22m\n \e[90m   @\e[39m \e[90m./\e[39m\e[90m\e[4mtiming.jl:689\e[24m\e[39m\e[90m [inlined]\e[39m\n [16] \e[0m\e[1mruntests\e[22m\e[0m\e[1m(\e[22m\e[90mname\e[39m::\e[0mString, \e[90mpath\e[39m::\e[0mString, \e[90misolate\e[39m::\e[0mBool; \e[90mseed\e[39m::\e[0mUInt128\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[35mMain\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mtestdefs.jl:25\e[24m\e[39m\n [17] \e[0m\e[1mruntests\e[22m\n \e[90m   @\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mtestdefs.jl:7\e[24m\e[39m\e[90m [inlined]\e[39m\n [18] \e[0m\e[1mkwcall\e[22m\e[0m\e[1m(\e[22m::\e[0m@NamedTuple\e[90m{seed::UInt128}\e[39m, ::\e[0mtypeof(runtests), \e[90mname\e[39m::\e[0mString, \e[90mpath\e[39m::\e[0mString\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[35mMain\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/test/\e[39m\e[90m\e[4mtestdefs.jl:7\e[24m\e[39m\n [19] \e[0m\e[1mkwcall\e[22m\e[0m\e[1m(\e[22m::\e[0m@NamedTuple\e[90m{seed::UInt128}\e[39m, ::\e[0mtypeof(invokelatest), ::\e[0mFunction, ::\e[0mString, ::\e[0mVararg\e[90m{String}\e[39m\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[90mBase\e[39m \e[90m./\e[39m\e[90m\e[4mBase_compiler.jl:253\e[24m\e[39m\n [20] \e[0m\e[1m(::Distributed.var\"#handle_msg##4#handle_msg##5\"{Distributed.CallMsg{:call_fetch}})\e[22m\e[0m\e[1m(\e[22m\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[36mDistributed\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/stdlib/v1.13/Distributed/src/\e[39m\e[90m\e[4mprocess_messages.jl:287\e[24m\e[39m\n [21] \e[0m\e[1mrun_work_thunk\e[22m\e[0m\e[1m(\e[22m\e[90mthunk\e[39m::\e[0mDistributed.var\"#handle_msg##4#handle_msg##5\"\e[90m{Distributed.CallMsg{…}}\e[39m, \e[90mprint_error\e[39m::\e[0mBool\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[36mDistributed\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/stdlib/v1.13/Distributed/src/\e[39m\e[90m\e[4mprocess_messages.jl:70\e[24m\e[39m\n [22] \e[0m\e[1m(::Distributed.var\"#handle_msg##2#handle_msg##3\"{Distributed.CallMsg{…}, Distributed.MsgHeader, Sockets.TCPSocket})\e[22m\e[0m\e[1m(\e[22m\e[0m\e[1m)\e[22m\n \e[90m   @\e[39m \e[36mDistributed\e[39m \e[90m/cache/build/tester-amdci4-13/julialang/julia-master/julia-073bb01fda/share/julia/stdlib/v1.13/Distributed/src/\e[39m\e[90m\e[4mprocess_messages.jl:287\e[24m\e[39m", "[5] \e[0m\e[1mcollect_to!\e[22m\e[0m\e[1m(\e[22m\e[90mdest\e[39m::\e[0mVector\e[90m{…}\e[39m, \e[90mitr\e[39m::\e[0mBase.Generator\e[90m{…}\e[39m, \e[90moffs\e[39m::\e[0mInt64, \e[90mst\e[39m::\e[0mInt64\e[0m\e[1m)\e[22m\n")

Tests were failing in this PR already, and failure isn't there in the previous commit before this PR was merged b63991c

[DilumAluthge]

This PR has been reverted in #59986.