Skip to content

Commit bd351ef

Browse files
committed
[unittest] Remove TODO comment which caused concern
Remove the second part of the TODO comment that highlighted an issue with possibly connecting all nodes to the exit of the CFG. This caused concerns with Jakub Kuderski regarding its feasability, hence we remove it. Such points are better discussed outside of CFG. If connecting all nodes makes sense and what the impact is is currently part of an active review discussion. llvm-svn: 309919
1 parent 8c549de commit bd351ef

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/unittests/IR/DominatorTreeTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ TEST(DominatorTree, DeletingEdgesIntroducesUnreachables) {
454454
// PDT. We also verify this property.
455455
//
456456
// TODO: Can we change the PDT definition such that C remains part of the
457-
// CFG, at best without loosing the dominance relation D postdom B.
457+
// CFG?
458458
TEST(DominatorTree, DeletingEdgesIntroducesInfiniteLoop) {
459459
StringRef ModuleString =
460460
"define void @f() {\n"

0 commit comments

Comments
 (0)