Skip to content
This repository was archived by the owner on May 21, 2022. It is now read-only.

WIP: More tests #3

Merged
merged 10 commits into from
Jun 29, 2017
Merged

WIP: More tests #3

merged 10 commits into from
Jun 29, 2017

Conversation

abieler
Copy link
Contributor

@abieler abieler commented Jun 26, 2017

No description provided.

@Evizero
Copy link
Member

Evizero commented Jun 26, 2017 •
edited
Loading

since I made a squash merge of #2 you may need to git rebase. sorry about that

@Evizero
Copy link
Member

Evizero commented Jun 26, 2017 •
edited
Loading

or I'll just roll back master. Carry on I'll take care of this

edit: done

@abieler
Copy link
Contributor Author

abieler commented Jun 26, 2017

LOL just did the rebase before I saw you edited your post..

@Evizero
Copy link
Member

Evizero commented Jun 26, 2017

that shouldn't be a problem since current master is an ancestor

@Evizero
Copy link
Member

Evizero commented Jun 26, 2017

sorry for making this more complicated still

@coveralls
Copy link

coveralls commented Jun 26, 2017 •
edited
Loading

Coverage Status

Coverage increased (+23.3%) to 91.045% when pulling 7588257 on more_tests into 487e601 on master.

@JuliaML JuliaML deleted a comment from coveralls Jun 26, 2017
@abieler
Copy link
Contributor Author

abieler commented Jun 26, 2017

If tests pass, ready to merge from my side. The last commit was to remove left overs from the "one-hot" discussion.

Evizero
Evizero reviewed Jun 26, 2017
View reviewed changes
test/tst_fixedrangescaler.jl.orig Outdated
@@ -0,0 +1,302 @@
X = collect(Float64, reshape(1:40, 10, 4))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be an artefact from the rebase and should be deleted before merging

@Evizero Evizero self-requested a review June 26, 2017 12:39
@abieler
Copy link
Contributor Author

abieler commented Jun 29, 2017

There are 2 depwarns left for v0.6, but from the testing part, not the actual module.
Tried to get rid of them with compat but failed miserably...
Otherwise ready to merge I d say.

@Evizero
Copy link
Member

Evizero commented Jun 29, 2017

I'll look into it. I reserved some time later today for github related things and this PR is on the top of my list. Thanks for putting so much effort into this. This package is turning into something really useful really quickly.

@Evizero Evizero merged commit eb003b4 into master Jun 29, 2017
@Evizero Evizero deleted the more_tests branch June 29, 2017 21:09
@Evizero Evizero removed their request for review June 29, 2017 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Evizero Evizero Evizero left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abieler @Evizero @coveralls